[LEDE-DEV] mktplinkfw2 cleanup tests (was [PATCH 1/3] mktplinkfw2: use hw rev for board detection too)

[Sergey Ryazanov]

Hello Mathias,

On Thu, Oct 5, 2017 at 9:13 AM, Mathias Kresin <dev at kresin.me> wrote:
> At the moment I'm reviewing https://github.com/lede-project/source/pull/1399

[skipped]

> The PR drops any hardcoded board params from mktplinkfw2.c in favour of
> commandline arguments, to provide only one way of creating tp-link images.
> It has the nice benefit that this file most likely doesn't need to be
> touched any more if new tp-link boards gets added.
>
> Would be nice if you can give the PR a try to test for regressions.

It's better late than never.

I had tested these patches, which already landed to the tree. All work
as expected. I had not test upgrading from vendor firmware to LEDE,
but sysupgrade works well with the new image on TP-Link Archer C20v1.
So image generation is still alive after these change.



P.S. I noticed that the old configuration is not preserved during the
sysupgrade. sysupgrade.tgz archive is generated and appended to the
jffs2 partition, as expected. But the archive is disappears (with all
the old configs) during the first boot after sysupgrade. It seems that
preserving the config has never worked with C20/C20i so latest changes
in mktplink2 had nothing to do with this.

-- 
Sergey