[LEDE-DEV] fixing of image file names

[Daniel Golle]

On Tue, Nov 28, 2017 at 08:16:33PM +0100, Moritz Warning wrote:
> Ok,
> 
> looks like I should make a patch. :P
> 
> On 11/28/2017 07:24 PM, Daniel Golle wrote:
> > Hi Moritz,
> > 
> > thanks for stepping forward and adressing this issue.
> > It'd be good to include the two assertions added to your list beelow.
> > 
> > On Tue, Nov 28, 2017 at 07:05:23PM +0100, Moritz Warning wrote:
> >> Hi,
> >>
> >> I noticed that there are some image file names that do not follow the "common" name scheme.
> >> Is it ok to change it? I would like to submit a patch.
> >>
> >> Some examples:
> >> - all lower case image names
> >>   - lede-ipq806x-EA8500-squashfs-sysupgrade.tar => lede-ipq806x-ea8500-squashfs-sysupgrade.tar
> >> - revision between -
> >>   - lede-mvebu-linksys-wrt1900acv2-squashfs-sysupgrade.bin => lede-mvebu-linksys-wrt1900ac-v2-squashfs-sysupgrade.bin
> >> - region specific images with region identifiers (us, eu, il, ...)
> >>  - lede-ramips-rt305x-wnce2001-squashfs-factory-northamerica.bin => lede-ramips-rt305x-wnce2001-us-squashfs-factory.bin
> >> - separate images for each version
> >>   - lede-brcm47xx-mips74k-linksys-e1000-v1-v2-v2.1-squashfs.bin => lede-brcm47xx-mips74k-linksys-e1000-v1-squashfs.bin, ...
> > 
> >  - board_name (in target userspace) == profile (in imagebuilder) == DTS name
> What is the target userspace and what does DTS mean?

`ubus call system board` contains the board_name


DTS name is the device-tree source filename, e.g.
`sun7i-a20-bananapi-m1-plus.dts`

Non-legacy (ie. device-tree-based) targets already partially enforce
this rule, but it's by no means consitent (yet)...


> 
> > 
> >  - image_filename == ${distro}-${target}-${subtarget}-${board_name}-${fstype}-${imgtype}
> > 
> > that would make identifying sysupgrade images much more straight
> > forward (and hence automatizable).
> > 
> > See also
> > https://github.com/aparcar/attendedsysupgrade-server/issues/80
> > 
> > 
> > Cheers
> > 
> > 
> > Daniel
> > 
> 
> 
> _______________________________________________
> Lede-dev mailing list
> Lede-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev