[LEDE-DEV] Broken USB LED trigger on LEDE 17.01.4?

[Florian Fainelli]

On 10/29/2017 12:28 AM, Rafał Miłecki wrote:
> On 2017-10-28 21:59, Florian Fainelli wrote:
>> I recently updated my Netgear WNDR4300 to LEDE 17.01.4 and the only
>> thing that appears broken is the USB LED trigger. The LED works fine
>> and while the USB port is detected, functional, setting it as a
>> trigger does not make the LED blink. Was there any fix not backported
>> to the lede-17.01 branch?
> 
> I just tested my SmartRG SR400ac with 17.01.4 and it works fine.
> 
> root at LEDE:~# cat /sys/class/leds/bcm53xx\:green\:usb3/trigger
> none nand-disk timer default-on netdev [usbport]
> root at LEDE:~# cat /sys/class/leds/bcm53xx\:green\:usb3/ports/* | grep -c 1
> 2
> 
> root at LEDE:~# cat /sys/class/leds/bcm53xx\:white\:usb3/trigger
> none nand-disk timer default-on netdev [usbport]
> root at LEDE:~# cat /sys/class/leds/bcm53xx\:white\:usb3/ports/* | grep -c 1
> 1
> 
> root at LEDE:~# cat /sys/class/leds/bcm53xx\:white\:usb2/trigger
> none nand-disk timer default-on netdev [usbport]
> root at LEDE:~# cat /sys/class/leds/bcm53xx\:white\:usb2/ports/* | grep -c 1
> 2
> 
> I also verified that plugging USB devices actually lights up the LED.

Wait, the LED does light up for me, but it's not blinking on USB
activity like it used to, did that actually change? I can't quite spot
in the following patches where the blinking on activity would actually
occur:

target/linux/generic/pending-4.4/084-0001-usb-core-Introduce-a-USB-port-LED-trigger.patch

> 
> I see that ar71xx has an entry for WNDR4300:
> ucidef_set_led_usbdev "usb" "USB" "netgear:green:usb" "1-1"
> maybe it's not working for some reason?
> 
> After flashing the firmware, what's the output for
> cat /sys/class/leds/netgear\:green\:usb/trigger
> cat /sys/class/leds/netgear\:green\:usb/ports/*

-- 
Florian