[LEDE-DEV] [PATCH 4/4] toolchain: musl: update to current HEAD

[Christian Lamparter]

On Wednesday, November 22, 2017 9:55:39 AM CET Koen Vandeputte wrote:
> >> Yes,
> >>
> >> Main reason in that specific case was mainly for these 2 fixes:
> >>
> >> /9e01be6 fix signal masking race in pthread_create with priority (I use
> >> lots of threading & thread priority in my app) //51bdcdc fix OOB reads in Xbyte_memmem (used by memmem() ) /
> >>
> > Hm? Are you now talking about something else? I remember seeing these
> > commits listed in your musl update to 1.1.16+.
> > <http://lists.infradead.org/pipermail/lede-dev/2017-October/009234.html>
> >
> > But Felix did the update musl to 1.1.18 on the 5th (I noticed that he had
> > a patch queued). This update included the changes you listed, right?
> >
> I was indeed referring to that one, as a mere example where I proposed 
> to bump to head, just like you propose now. (got superseded)
> http://patchwork.ozlabs.org/patch/823135/
Ah ok, I misread this at first and got confused. Thank you for taking the
time to explain what was going on here.

In any case it seems like the commits entered Felix's staging tree.
<https://git.lede-project.org/?p=lede/nbd/staging.git>

> > Maybe a balanced solution would be to wait for 1 .. 2  tested-by's
> > before pushing these to master?
> > Great that you bring this up. So, did you test >this patch< already too?
> > And if so, what's your verdict? Does it perform as expected on your cns3xxx?
> > Can you please post a "tested-by" tag then?
> I've added it to my daily build yesterday, and it's running on my stress 
> setup currently. (9 boards: 6x cns3xxx & 3x imx6, all meshed up)
> If all goes well, I'm more that happy to drop a tested-by within the 
> next few hours (like I sometimes do for other people's patches too)
Yes, I saw Kevin and your mail too. Thank you both! :)

> Feel free to do the same for mine ;)
Yes, of course. Please do include me in the "CC:", this way it will
hit my inbox, instead of being delivered to just the Mailinglist folder.

The linux kernel ships with a rather useful perl script called:
get_maintainer.pl. (Yes, it can be a blessing but it can also be a curse)

Long ago, this script required a project maintain a special MAINTAINERS file.
However nowadays, the tool has the ability to extract this information from 
git by looking at the previous commits (Emails from Signed-off-by: Reviewed-by:
and Acked-by: tags). And for the most part, this is compatible with LEDE's 
patch guidelines. <https://lede-project.org/submitting-patches>

For example, for this patch it will generate the following output:

$ get_maintainer.pl 0004-toolchain-musl-update-to-current-HEAD.patch 
Felix Fietkau <nbd at nbd.name> (authored:3/7=43%,added_lines:5/17=29%,removed_lines:5/14=36%,authored:1/2=50%,added_lines:3/54=6%,removed_lines:3/22=14%)
Christian Lamparter <chunkeey at gmail.com> (authored:2/7=29%,added_lines:8/17=47%,removed_lines:5/14=36%,authored:1/2=50%,added_lines:51/54=94%,removed_lines:19/22=86%)
Koen Vandeputte <koen.vandeputte at ncentric.com> (authored:2/7=29%,added_lines:4/17=24%,removed_lines:4/14=29%)

So, this tool has picked you as a reviewer! ;)

If you (or anyone else) want to check it out, I've uploaded this slightly
modified version github gist [removed "linux kernel" references in help texts
and changed top_of_kernel_tree() func to work for the LEDE's root directory.]
<https://gist.github.com/chunkeey/59c4b814243e384c05d89cdef2ced916>
(To download, press "Raw" button)

Is there any interest for this?

Regards,
Christian