[LEDE-DEV] [PATCH] samba36: Disable by default

Rosen Penev rosenp at gmail.com
Mon Nov 20 19:49:13 PST 2017


sendfile has been tested to have stability issues with at least mt7621 and mvebu. With both, I've had the system reboot(no logs unfortunately). It usually happens when seeking multiple times with a single video file. A different user said disabling sendfile improved her uptime from a few hours to around 10 days.

Disable and add a comment warning the user.

Signed-off-by: Rosen Penev <rosenp at gmail.com>
---
 package/network/services/samba36/Makefile                | 2 +-
 package/network/services/samba36/files/smb.conf.template | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/network/services/samba36/Makefile b/package/network/services/samba36/Makefile
index 5564a78404..42c23b4e8e 100644
--- a/package/network/services/samba36/Makefile
+++ b/package/network/services/samba36/Makefile
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=samba
 PKG_VERSION:=3.6.25
-PKG_RELEASE:=8
+PKG_RELEASE:=9
 
 PKG_SOURCE_URL:=https://download.samba.org/pub/samba \
 		https://download.samba.org/pub/samba/stable
diff --git a/package/network/services/samba36/files/smb.conf.template b/package/network/services/samba36/files/smb.conf.template
index fc72f9258c..36bf73039d 100644
--- a/package/network/services/samba36/files/smb.conf.template
+++ b/package/network/services/samba36/files/smb.conf.template
@@ -17,4 +17,4 @@
 	passdb backend = smbpasswd
 	security = user
 	smb passwd file = /etc/samba/smbpasswd
-	use sendfile = yes
+	use sendfile = no ;unstable - enable at your own risk
-- 
2.14.3




More information about the Lede-dev mailing list