[LEDE-DEV] [PATCH v2] base-files: Don't deconfigure IP settings while using NFS root

[John Crispin]

On 08/11/17 08:01, John Crispin wrote:
>
>
> On 06/11/17 15:39, Petr Štetiar wrote:
>> This patch allows me to boot my system with root file system mounted 
>> over
>> Network File System (NFS). Without this patch, the boot process ends 
>> in the
>> preinit step:
>>
>>     init: - preinit -
>>     ...
>>     + [ eth0 = eth0+ ip link set dev eth0 down
>>     nfs: server 192.168.1.90 not responding, still trying
>>
>> Signed-off-by: Petr Štetiar <ynezz at true.cz>
>> ---
>>   package/base-files/files/lib/preinit/10_indicate_preinit | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/package/base-files/files/lib/preinit/10_indicate_preinit 
>> b/package/base-files/files/lib/preinit/10_indicate_preinit
>> index 7a97a8d..457ce21 100644
>> --- a/package/base-files/files/lib/preinit/10_indicate_preinit
>> +++ b/package/base-files/files/lib/preinit/10_indicate_preinit
>> @@ -114,6 +114,8 @@ preinit_ip() {
>>   }
>>     preinit_ip_deconfig() {
>> +    grep -q "nfsroot" /proc/cmdline && return
>> +
>>       [ -n "$pi_ifname" ] && grep -q "$pi_ifname" /proc/net/dev && {
> Hi,
>
> wondering if it would be nicer to add this to the already existing if 
> clause.
>            [ -z "$(grep "nfsroot" /proc/cmdline)" ] && ...
>     John

and please add a comment in the code stating that deconf should be 
skipped when booting from a nfs rootfs

     John
>
>>           local netdev vid
>
>
> _______________________________________________
> Lede-dev mailing list
> Lede-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev