[LEDE-DEV] [PATCH] ramips: Add support for the Unielec U7621-6

[Mathias Kresin]

05.11.2017 13:56, Kristian Evensen:
> Hi again,
> 
> On Sun, Nov 5, 2017 at 12:14 PM, Mathias Kresin <dev at kresin.me> wrote:
>>> diff --git a/target/linux/ramips/image/mt7621.mk
>>> b/target/linux/ramips/image/mt7621.mk
>>> index 8bd7e0318f..1bdd0024e4 100644
>>> --- a/target/linux/ramips/image/mt7621.mk
>>> +++ b/target/linux/ramips/image/mt7621.mk
>>> @@ -225,6 +225,15 @@ define Device/timecloud
>>>    endef
>>>    TARGET_DEVICES += timecloud
>>>    +define Device/u7621-6-256M-16M
>>> +  DTS := U7621-6-256M-16M
>>> +  IMAGE_SIZE := 16777216
>>
>>
>> Looks wrong to me. The firmware partition has a size of 0xfb0000, which is
>> 16449536 bytes or 16064k to be better readable.
> 
> I think maybe I was a bit quick in my previous email. Are you sure
> about this comment? I am happy to change the size, but the firmware
> partition starts at 0x50000 and 0x50000 + 0xfb0000 == 16777216. So
> that is why I sat the image size to the current value.
> 
> -Kristian
> 

Yes I am. The firmware partition has a size of 0xfb0000 (0x50000 is the 
offset of the partition relative to the start of the flash), hence the 
image written to the firmware partition can't be bigger than that.

16777216 bytes would cover the whole flash chip but you do not intend to 
write to the u-boot, u-boot-env and factory partitions.

Mathias