[LEDE-DEV] [PATCH mountd 1/2] mount: drop duplicated filesystem check from mount_add_list

Rafał Miłecki zajec5 at gmail.com
Fri Nov 3 02:02:39 PDT 2017


From: Rafał Miłecki <rafal at milecki.pl>

At the very beginning of this function there is following code:
if(fs <= MBR || fs > LASTFS)
	return;

There is no point in checking for the same range again as these checks
will always evaluate into true.

Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
---
 mount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mount.c b/mount.c
index 92606da..6d95de9 100644
--- a/mount.c
+++ b/mount.c
@@ -155,7 +155,7 @@ static void mount_add_list(char *name, char *dev, char *serial,
 	mount->mounted = 0;
 	mount->fs = fs;
 	list_add(&mount->list, &mounts);
-	if((!mount->ignore) && (mount->fs > MBR) && (mount->fs <= LASTFS))
+	if (!mount->ignore)
 	{
 		log_printf("new mount : %s -> %s (%s)\n", name, dev, fs_names[mount->fs]);
 		snprintf(tmp, 64, "%s%s", uci_path, name);
-- 
2.11.0




More information about the Lede-dev mailing list