[LEDE-DEV] Busybox weirdness

[Philip Prindeville]

> On Nov 2, 2017, at 4:24 AM, edgar.soldin at web.de wrote:
> 
> hey Phillip,
> 
> On 02.11.2017 03:36, Philip Prindeville wrote:
>> Can someone else please try to reproduce this?
> 
> yes, not exactly but wrong resulting file name nonetheless. it's obviously a bug. looks like a variable reuse went awry as it always hit's the second file, having fragments of the first file's name. i switched the files you downloaded, just to test if there might be a server side influence.
> 
> :/tmp# wget http://geolite.maxmind.com/download/geoip/database/GeoIPCountryCSV.zip http://geolite.maxmind.com/download/geoip/database/GeoIPv6.csv.gz
> Downloading 'http://geolite.maxmind.com/download/geoip/database/GeoIPCountryCSV.zip'
> Connecting to 2400:cb00:2048:1::6810:262f:80
> Writing to 'GeoIPCountryCSV.zip'
> GeoIPCountryCSV.zip  100% |*******************************|  2338k  0:00:00 ETA
> Download completed (2394696 bytes)
> Connecting to 2400:cb00:2048:1::6810:252f:80
> Writing to 'w;o▒w;o▒ntryCSV.zip'
> w;o▒w;o▒ntryCSV.zip  100% |*******************************|  1496k  0:00:00 ETA
> Download completed (1532219 bytes)
> 
> vs.
> 
> :/tmp# wget http://geolite.maxmind.com/download/geoip/database/GeoIPv6.csv.gz http://geolite.maxmind.com/download/geoip/database/GeoIPCountryCSV.zip
> Downloading 'http://geolite.maxmind.com/download/geoip/database/GeoIPv6.csv.gz'
> Connecting to 2400:cb00:2048:1::6810:262f:80
> Writing to 'GeoIPv6.csv.gz'
> GeoIPv6.csv.gz       100% |*******************************|  1496k  0:00:00 ETA
> Download completed (1532219 bytes)
> Connecting to 2400:cb00:2048:1::6810:252f:80
> Writing to 'w▒o▒w▒o▒csv.gz'
> w▒o▒w▒o▒csv.gz       100% |*******************************|  2338k  0:00:00 ETA
> Download completed (2394696 bytes)
> 
> this is on a Lede 17.01-SNAPSHOT, r3535+35-ee32de4 with '/bin/wget -> uclient-fetch' on an Ubiquiti Loco M2.
> 
> ..ede


Thank you both for looking into this.

I poked around the code last night after sending out that email, and found that “output_file” was being overloaded and this was causing some side-effects.

I have a tentative fix which I’ll send out.

-Philip