[LEDE-DEV] [RFC PATCH] tools/squashfs: change to upstream and update to new version 5.0-rc1

[Phillip Lougher]

On 05/26/2017 06:13 PM, Alexander Couzens wrote:
> squashfs is quite long unmaintained. All patches from major
> distributions are integrated.

 >include/image.mk                                   |   3 +-
 >tools/squashfs4/Makefile                           |  12 +-
 >tools/squashfs4/patches/100-portability.patch      |  40 -
 >.../patches/110-allow_static_liblzma.patch         |  30 -
 >tools/squashfs4/patches/120-cygwin_fixes.patch     | 153 ----
 >tools/squashfs4/patches/150-freebsd_fixes.patch    |  10 -
 >.../patches/160-expose_lzma_xz_options.patch       | 929 ---------------------

Why are you adding compression options support to the LZMA1 compression code?

The LZMA1 compressor is deprecated and obsolete, as mentioned in the
official release Makefile

########### Building LZMA support #############
#
# LZMA1 compression.
#
# LZMA1 compression is deprecated, and the newer and better XZ (LZMA2)
# compression should be used in preference.
#
# Both XZ Utils liblzma (http://tukaani.org/xz/) and LZMA SDK
# (http://www.7-zip.org/sdk.html) are supported
#
# To build using XZ Utils liblzma - install the library and uncomment
# the LZMA_XZ_SUPPORT line below.
#
# To build using the LZMA SDK (4.65 used in development, other versions may
# work) - download and unpack it, uncomment and set LZMA_DIR to unpacked source,
# and uncomment the LZMA_SUPPORT line below.

There are two reasons for this:

1. The kernel code for LZMA1 support got rejected, and it is never
going to be mainlined.

2. The LZMA1 author requested I deprecate it in favour of XZ.

Cheers

Phillip