[LEDE-DEV] [PATCH 2/3] usbmode: update usb-modeswitch-data to 20170205

Piotr Dymacz pepe2k at gmail.com
Wed May 24 09:07:49 PDT 2017


Hi Felix,

On 24.05.2017 17:54, Felix Fietkau wrote:
> On 2017-05-24 17:14, Piotr Dymacz wrote:
>> Hello Julian,
>> 
>> On 24.05.2017 16:32, Julian Labus wrote:
>>> add support for new hardware
>> 
>> Thanks for taking care of this.
>> 
>> If you want to keep usb-modeswitch-data version bump in a separate 
>> commit, I suppose that the PKG_RELEASE should be increased, according to 
>> the "Packaging guidelines" [1].
>> 
>> Or, maybe it make sense to squash both versions update commits.
>> 
>> [1] https://forum.lede-project.org/t/packaging-guidelines/65/2
> I think a PKG_RELEASE bump makes no sense here, neither does squashing
> the commits together.

OK, PKG_RELEASE value maintaining was always confusing for me.

--
Cheers,
Piotr

> Since the commits are going to be pushed at the same time, there will
> not be a snapshot build inbetween...
> 
> - Felix
> 




More information about the Lede-dev mailing list