[LEDE-DEV] [PATCH v2] ipq806x: Add support for ipq40xx AP-DK01.1-C1 and AP-DK04.1-C1

[Ram Chandra Jangir]

On Freitag, Monday, May 22, 2017 7:22 PM Sven Eckelmann wrote:
>On Freitag, 21. April 2017 00:25:37 CEST Ram Chandra Jangir wrote:
> +@@ -419,18 +424,19 @@
> +                       status = "disabled";
> +
> +                       gmac0: gmac0 {
> +                               local-mac-address = [00 00 00 00 00 00];
> +-                              vlan_tag = <1 0x1f>;
> +-                      };
> +-
> +-                      gmac1: gmac1 {
> +-                              local-mac-address = [00 00 00 00 00 00];
> +                               qcom,phy_mdio_addr = <4>;
> +                               qcom,poll_required = <1>;
> +                               qcom,forced_speed = <1000>;
> +                               qcom,forced_duplex = <1>;
> +                               vlan_tag = <2 0x20>;
> +                       };
> ++
> ++                      gmac1: gmac1 {
> ++                              local-mac-address = [00 00 00 00 00 00];
> ++                              qcom,poll_required_dynamic = <1>;
> ++                              vlan_tag = <1 0x1e>;
> ++                      };

>Why did you swap the gmac0 and gmac1 interface? I would guess that you have
to fix the network setup for the other devices (qcom-ipq4019-rt-ac58u.dts,
qcom- ipq4019-nbg6617.dts, qcom-ipq4019-fritz4040.dts) when you do that.

>Kind regards,
>	Sven


Thanks Sven,

Normally we configure gmac0 for  WAN group and gmac1 for  LAN group,
existing ipq806x boards are also following the same, and we would like to
continue with the  same convention. I do not see any reason to deviate this
in ipq40xx based boards.
I agree that ac58u nbg6617 and fritz4040 needs some changes, and Christian
can help us to make the same.

Thanks,
Ram