[LEDE-DEV] [PATCH] ipq806x: Add nand boot support for ipq40xx AP-DK04.1-C1

[Ram Chandra Jangir]

Thanks Chris Blake,

>First off, thank you very much for this patch and your work on the ipq40xx platform. I have been doing more testing, and it seems that some of the pins in pinctl are not defined to the correct function.
>This is what I am currently seeing on the board:

> [    1.278649] ipq4019-pinctrl 1000000.pinctrl: invalid group "gpio57"
>for function "qpic_pad"
> [    1.279841] ipq4019-pinctrl 1000000.pinctrl: invalid group "gpio58"
>for function "qpic_pad"
> [    1.288214] ipq4019-pinctrl 1000000.pinctrl: invalid group "gpio59"
>for function "qpic_pad"
> [    1.296508] ipq4019-pinctrl 1000000.pinctrl: invalid group "gpio60"
>for function "qpic_pad"
> [    1.304905] ipq4019-pinctrl 1000000.pinctrl: invalid group "gpio64"
>for function "qpic_pad"
> [    1.313190] ipq4019-pinctrl 1000000.pinctrl: invalid group "gpio65"
>for function "qpic_pad"
> [    1.321522] ipq4019-pinctrl 1000000.pinctrl: invalid group "gpio66"
>for function "qpic_pad"
> [    1.329856] ipq4019-pinctrl 1000000.pinctrl: invalid group "gpio67"
>for function "qpic_pad"
> [    1.338190] ipq4019-pinctrl 1000000.pinctrl: invalid group "gpio68"
>for function "qpic_pad"

>With that said, NAND still inits and works. I was also able to clear up the errors by fixing the groups for each GPIO in my DTS with the help of Christian. Example of this is at https://pastebin.com/rQDY3z9c.

>Is this something specific with my board, or some other variation with your patch? I am new to this arch so please excuse me if any of this is noobish. :)

Pinctrl driver has proper definitions & values  for  respective GPIO's  in the patch and I did not observe such issues in IPQ4019 DK01, DK04 and other variants of Dakota boards, they work fine as expected.

Thanks,
Ram