[LEDE-DEV] [PATCH v4] dnsmasq: also write /tmp/resolv.conf when UCI dhcp.dnsmasq.noresolv is '1'

[Paul Oranje]

ad. 1) FS785 describes why, please have a look there.
ad. 2) the patched code has been tested.

Producing the submission of the patch for this trivial and simple change has provided me with the opportunity to make almost every error imaginable, and as you have noticed, I greatly succeeded at doing just that. The spam is an unwanted side effect.

I’ve submitted a last version of this patch, s.y.
Paul


> Op 14 mei 2017, om 18:54 heeft Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk> het volgende geschreven:
> 
> 
> 
> On 14/05/17 17:48, Alberto Bursi wrote:
>> 
>> 
>> On 05/14/2017 02:46 PM, Paul Oranje wrote:
>>> fixes FS#785
>>> ---
>>> 
>>>  v4: place patch version info in annotation (not in commit message, afraid this is learning by practice)
>>>  v3: corrected typo (noreolv)
>>>  v2: also change guard in dnsmasq_stop() routine
>>>  v1: write /tmp/resolv.conf also when noresolv is true
> 
> Having seen so many versions go by...the overriding questions for me are
> 
> 1) Why do we want this?
> 2) Has any of it actually been tested?
> 
> _______________________________________________
> Lede-dev mailing list
> Lede-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev