[LEDE-DEV] [PATCH] ramips: Add support for GL-MT300N-V2

Piotr Dymacz pepe2k at gmail.com
Tue May 9 00:32:41 PDT 2017


Hello Thomas,

On 04.05.2017 21:30, Thomas Endt wrote:
>> -----Ursprüngliche Nachricht-----
>> von Piotr Dymacz
>> Gesendet: Donnerstag, 4. Mai 2017 10:30
>>
>> Hello,
>>
>> Please, make sure to add a proper SoB line as described in "Submitting
>> patches": [1].
>>
>> Also, could you please include in your commit message short description
>> about the hardware and how to install LEDE on it? Have a look at the
>> recent ramips board additions for some examples: [2].
>>
>> [1] https://lede-project.org/submitting-patches
>> [2]
>> https://github.com/lede-
>> project/source/search?&q=ramips+add+support+for&type=Commits
>
> I think it would make sense to add a note to [1] regarding hardware
> description and install instructions. This is really helpful information for
> adding devices to the Table of Hardware, especially for devices where not
> much if any information can be found on the net. Hopefully it will also save
> you from having to repeat that note with each new "add support for..."
> commit.
>
> Thomas

I just saw that you already did it 2 days ago:
https://lede-project.org/submitting-patches?rev=1494176457

Thank you!

--
Cheers,
Piotr




More information about the Lede-dev mailing list