[LEDE-DEV] [PATCH] lantiq: dsl_notify: also restart pppoe interfaces

Mathias Kresin dev at kresin.me
Mon May 8 23:46:02 PDT 2017


09.05.2017 00:44, Valentin Spreckels:
> Signed-off-by: Valentin Spreckels <Valentin.Spreckels at Informatik.Uni-Oldenburg.DE>
> ---

Thanks a lot for your patch. Would you please add a commit message which 
describes the issue you are trying to fix. At the moment I fail to see 
why this change is required.

I rather suspect that the whole pppoa interface handling can be removed 
from dsl_notify.sh. Isn't it handled by netifd now days?

Mathias

>  target/linux/lantiq/base-files/sbin/dsl_notify.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/linux/lantiq/base-files/sbin/dsl_notify.sh b/target/linux/lantiq/base-files/sbin/dsl_notify.sh
> index 11ada92..8503ab4 100755
> --- a/target/linux/lantiq/base-files/sbin/dsl_notify.sh
> +++ b/target/linux/lantiq/base-files/sbin/dsl_notify.sh
> @@ -33,7 +33,7 @@ for ifc in $interfaces; do
>  	json_load "$(ifstatus $ifc)"
>
>  	json_get_var proto proto
> -	if [ "$proto" != "pppoa" ]; then
> +	if [ "$proto" != "pppoa" -a "$proto" != "pppoe" ]; then
>  		continue
>  	fi
>
>




More information about the Lede-dev mailing list