[LEDE-DEV] [PATCH 1/5] base-files: introduce /lib/functions/board.sh

[Felix Fietkau]

On 2017-05-02 19:32, Roman Yeryomin wrote:
> I just want to save maintenance time. As you admit it's already a
> clutter. I'm trying to introduce some order.
> Actually uci-defaults is another one which doesn't need 90% of
> functions.sh (it only needs list_contains).
> I would propose breaking down functions.sh into smaller files by
> functionality, e.g. config/user/base/etc., together with optimizing
> it's usage in other scripts.
> Then /lib/functions.sh could become a meta include which includes
> everything under /lib/functions/. It would be more logical and
> structurally more right than including functions.sh from a script from
> /lib/functions/.
I think effectively you're making the whole thing slower and bigger at
the same time. Processing the extra includes certainly results in extra
syscalls and extra overhead, maybe even extra memory overhead.
Additionally I'd say it does nothing to make the maintenance any easier.
Please don't go that route, it really doesn't help.

- Felix