[LEDE-DEV] [PATCH] build: Fix unpacking of overlaid packages

[Michal Sojka]

Hi Yousong,

On Thu, Mar 23 2017, Yousong Zhou wrote:
> On 18 March 2017 at 06:54, Michal Sojka <sojkam1 at fel.cvut.cz> wrote:
>> On Fri, Mar 17 2017, Michal Sojka wrote:
>>> Since commit 5af113eb7c0f6e4b2d09e536e1a2adc4e2d6071d, LEDE's build
>>> system contains overlay functionality, which allows to locally amend
>>> properties of packages. When one wants to overlay certain properties
>>> such as PKG_VERSION, the unpack command (UNPACK_CMD) uses the original
>>> value rather than the overlaid one and unpacking fails.
>>
>> Hmm, there are more places where is this overlay functionality broken.
>> I'll send another patch that makes it work for me, but there are places,
>> which cannot be fixed that easy. One of them is the -iremap CFLAG, which
>> is appended to TARGET_CFLAGS with "+=" operator, which expands to the
>> non-overlaid path.
>>
>> -Michal
>
> The change will incur too much implementation details and is very
> likely hard to maintain later.

Yes, I think the same. IMHO, the best thing to do would be to remove the
package overlay code, because it either does not work at all or it works
only in a few very limited (and undocumented) cases.

> In your case, I would recommend either maintaining your own branch, or
> maintain a package feed for your needs and prefer it at feed install
> time.

What do you mean by "prefer at feed install time"?

Thanks
-Michal