[LEDE-DEV] [PATCH libubox] md5: add "const" qualifier to the "file" argument

Yousong Zhou yszhou4tech at gmail.com
Mon Mar 20 04:42:01 PDT 2017


This is intended to fix the following compiler warning in opkg-lede:

    /home/yousong/git-repo/lede-project/opkg-lede/libopkg/file_util.c: In function ‘file_md5sum_alloc’:
    /home/yousong/git-repo/lede-project/opkg-lede/libopkg/file_util.c:144:2: warning: passing argument 1 of ‘md5sum’ discards ‘const’ qualifier from pointer target type [enabled by default]
    In file included from /home/yousong/git-repo/lede-project/opkg-lede/libopkg/file_util.c:28:0:
    /home/yousong/.usr/include/libubox/md5.h:56:5: note: expected ‘char *’ but argument is of type ‘const char *’

Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
---
 md5.c | 2 +-
 md5.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/md5.c b/md5.c
index 781dbd1..3f8ad28 100644
--- a/md5.c
+++ b/md5.c
@@ -308,7 +308,7 @@ void md5_end(void *resbuf, md5_ctx_t *ctx)
 	memset(ctx, 0, sizeof(*ctx));
 }
 
-int md5sum(char *file, void *md5_buf)
+int md5sum(const char *file, void *md5_buf)
 {
 	char buf[256];
 	md5_ctx_t ctx;
diff --git a/md5.h b/md5.h
index b2f1b80..d3ee4e3 100644
--- a/md5.h
+++ b/md5.h
@@ -53,6 +53,6 @@ typedef struct md5_ctx {
 extern void md5_begin(md5_ctx_t *ctx);
 extern void md5_hash(const void *data, size_t length, md5_ctx_t *ctx);
 extern void md5_end(void *resbuf, md5_ctx_t *ctx);
-int md5sum(char *file, void *md5_buf);
+int md5sum(const char *file, void *md5_buf);
 
 #endif
-- 
2.6.4




More information about the Lede-dev mailing list