[LEDE-DEV] [PATCH] imx6: add DSA driver for MV88E6176 switch

[Felix Fietkau]

On 2017-03-10 17:28, Tim Harvey wrote:
> On Fri, Mar 10, 2017 at 7:49 AM, Rafał Miłecki <zajec5 at gmail.com> wrote:
>> On 10 March 2017 at 16:01, Tim Harvey <tharvey at gateworks.com> wrote:
>>> The MV88E6176 switch is present on the GW16083 and the GW5904
>>>
>>> As of a5c32a1f1996f4f75504c4a9abd1c99eaa598df1 these drivers are to be
>>> enabled static in per-target kernels.
>>
>> A standard kernel syntax may be preferred:
>> commit a5c32a1f1996 ("kernel: remove switch driver kmod packages")
> 
> I can update the commit log if the patch requires rework.
> 
> honestly, I'm not all that happy about 'commit a5c32a1f1996 ("kernel:
> remove switch driver kmod packages")' which removed selecting dsa
> kernel modules because of perceived bloat but instead this puts bloat
> into the static kernel of other imx6 boards that dont' have DSA. At
> least before the modules were selectable.
Keeping it modular is a bad trade-off, because it was adding bloat to
non-imx6 platform kernel images where *no* board was using it. On many
of these, bloat is a real factor, as opposed the tiny cosmetic issue
that you're describing.

I'm pretty sure that no imx6 board is space constrained enough that
adding a few kilobytes to the kernel image actually matters in practice.

- Felix