[LEDE-DEV] [PATCH netifd 1/2] interface-ip: set address indicator flag when IPv6 address lifetime changes

[Matthias Schiffer]

On 03/09/2017 05:32 PM, Hans Dedecker wrote:
> Trigger interface update event when IPv6 address lifetime changes by setting
> the address indicator flag to inform external subsystems about IPv6 address
> lifetime change.
> 
> Signed-off-by: Hans Dedecker <dedeckeh at gmail.com>

AFAICT, this will cause a lot of ifupdate events in big IPv6 networks (for
example, some large mesh networks based on Gluon have more than 4000 client
and 5-10 radvds, often causing more than one RA per second, each updating
valid/preferred lifetimes). We *really* want to avoid causing lots of
reloads for services that set triggers on interface updates; the majority
of services is not interested in the lifetimes of addresses at all.

Matthias


> ---
>  interface-ip.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/interface-ip.c b/interface-ip.c
> index ddca5d2..366f69a 100644
> --- a/interface-ip.c
> +++ b/interface-ip.c
> @@ -563,8 +563,10 @@ interface_update_proto_addr(struct vlist_tree *tree,
>  			keep = false;
>  
>  		if (a_old->valid_until != a_new->valid_until ||
> -				a_old->preferred_until != a_new->preferred_until)
> +				a_old->preferred_until != a_new->preferred_until) {
> +			iface->updated |= IUF_ADDRESS;
>  			replace = true;
> +		}
>  
>  		if ((a_new->flags & DEVADDR_FAMILY) == DEVADDR_INET4 &&
>  		    a_new->broadcast != a_old->broadcast)
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/lede-dev/attachments/20170309/f61addaf/attachment.sig>