[LEDE-DEV] [PATCH] ar71xx: change image version to LEDE for ubiquiti devices

Mathias Kresin dev at kresin.me
Fri Mar 3 06:20:12 PST 2017


2017-03-03 14:52 GMT+01:00 txt.file <txt.file at txtfile.eu>:
> ar71xx: change image version to LEDE for ubiquiti devices
>
> Signed-off-by: txt.file <txt.file at txtfile.eu>

Fullname in Signed-off-by please.

Please add a commit message. Describe where the change is visible and
mention the feature request you've creating in flyspray, similar to
how it's done in
https://git.lede-project.org/9e740fa5a51fee102671209273f01798ea1d7694.

> ---
>  target/linux/ar71xx/image/ubnt.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/linux/ar71xx/image/ubnt.mk b/target/linux/ar71xx/image/ubnt.mk
> index 7a1fc80..cf6a70c 100644
> --- a/target/linux/ar71xx/image/ubnt.mk
> +++ b/target/linux/ar71xx/image/ubnt.mk
> @@ -6,7 +6,7 @@
>  # routerboard creates partitions out of the ubnt header
>  define Build/mkubntimage
>         -$(STAGING_DIR_HOST)/bin/mkfwimage \
> -               -B $(UBNT_BOARD) -v $(UBNT_TYPE).$(UBNT_CHIP).v6.0.0-OpenWrt-$(REVISION) \
> +               -B $(UBNT_BOARD) -v $(UBNT_TYPE).$(UBNT_CHIP).v6.0.0-LEDE-$(REVISION) \

Replacing one hardcoded value with another hardcoded value doesn't
seam to me the smartest idea. Please use the VERSION_DIST variable
instead.

Mathias



More information about the Lede-dev mailing list