[LEDE-DEV] [PATCH] hostapd: configure NAS ID regardless of encryption

[Yury Shvedov]

Fixed with acct_interval patch (your changes was not appeared at github
for now).

By the way, I believe, that configuring RADIUS, (even AUTH) without
WPA-EAP will not break anything at all (that is not definitely).
But I definitely saw the piece of code in hostapd which uses RADIUS-AUTH
on the 802.11-AUTH stage before 802.11-ACCT without EAP.

RADIUS protocol could be used not only for authentication but for
accounting too. Accounting could be configured for any type of networks.
However there no way to configure NAS Identifier for non-WPA-EAP
networks without this patch.

Signed-off-by: Yury Shvedov <yshvedov at wimarksystems.com>
---
 package/network/services/hostapd/files/hostapd.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/network/services/hostapd/files/hostapd.sh b/package/network/services/hostapd/files/hostapd.sh
index d94aa38807..8e3f88a115 100644
--- a/package/network/services/hostapd/files/hostapd.sh
+++ b/package/network/services/hostapd/files/hostapd.sh
@@ -212,7 +212,7 @@ hostapd_set_bss_options() {
 		wps_pushbutton wps_label ext_registrar wps_pbc_in_m1 wps_ap_setup_locked \
 		wps_independent wps_device_type wps_device_name wps_manufacturer wps_pin \
 		macfilter ssid wmm uapsd hidden short_preamble rsn_preauth \
-		iapp_interface eapol_version dynamic_vlan ieee80211w \
+		iapp_interface eapol_version dynamic_vlan ieee80211w nasid \
 		acct_server acct_secret acct_port acct_interval

 	set_default isolate 0
@@ -249,6 +249,7 @@ hostapd_set_bss_options() {
 		[ -n "$wpa_master_rekey" ] && append bss_conf "wpa_gmk_rekey=$wpa_master_rekey"  "$N"
 	}

+	[ -n "$nasid" ] && append bss_conf "nas_identifier=$nasid" "$N"
 	[ -n "$acct_server" ] && {
 		append bss_conf "acct_server_addr=$acct_server" "$N"
 		append bss_conf "acct_server_port=$acct_port" "$N"
@@ -376,9 +377,8 @@ hostapd_set_bss_options() {
 	}

 	if [ "$wpa" -ge "1" ]; then
-		json_get_vars nasid ieee80211r
+		json_get_vars ieee80211r
 		set_default ieee80211r 0
-		[ -n "$nasid" ] && append bss_conf "nas_identifier=$nasid" "$N"

 		if [ "$ieee80211r" -gt "0" ]; then
 			json_get_vars mobility_domain r0_key_lifetime r1_key_holder \
--
2.13.1