[LEDE-DEV] [RFC] kernel patches cleanup

Baptiste Jonglez baptiste at bitsofnetworks.org
Mon Jul 31 11:08:01 PDT 2017


On Mon, Jul 31, 2017 at 06:11:49PM +0200, John Crispin wrote:
> I rebased my ages old kernel patch cleanup series. It can be found here [1].
> 
> the series annotates all patches and splits them up into 3 folders
> backports/pending/hacks.
> 
> I'd like to push this asap if there are no mayor issues as it will be a pain
> to rebase once again

Just a minor note on your first patch 18f24f2ea2a28d04942db9d192496faf9f5f4cbc:

> diff --git a/include/quilt.mk b/include/quilt.mk
> index 7f525e2e93..61dcc7964c 100644
> --- a/include/quilt.mk
> +++ b/include/quilt.mk
> @@ -124,7 +130,9 @@ define Quilt/Refresh/Kernel
>                 echo "All kernel patches must start with either generic/ or platform/"; \
>                 false; \
>         }
> +       $(call Quilt/RefreshDir,$(PKG_BUILD_DIR),$(GENERIC_BACKPORT_DIR),generic-backport/)
>         $(call Quilt/RefreshDir,$(PKG_BUILD_DIR),$(GENERIC_PATCH_DIR),generic/)
> +       $(call Quilt/RefreshDir,$(PKG_BUILD_DIR),$(GENERIC_HACK_DIR),generic-hack/)
>         $(call Quilt/RefreshDir,$(PKG_BUILD_DIR),$(PATCH_DIR),platform/)
>  endef

I think you can get rid of the check just above ("All kernel patches must
start with either generic/ or platform/"), because it is now incorrect.

Anyway, this is mostly cosmetic, because the check seems to be broken (it
does not trigger even after your changes).

Baptiste
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/lede-dev/attachments/20170731/aa27493e/attachment.sig>


More information about the Lede-dev mailing list