[LEDE-DEV] [PATCH] busybox: update to 1.27.1

Magnus Kroken mkroken at gmail.com
Sat Jul 29 14:36:23 PDT 2017


Hi Baptiste, thanks for looking over it

On 29.07.2017 22:48, Baptiste Jonglez wrote:
> Thanks for the update!  You can drop 120-remove_uclibc_rpc_check.patch
> altogether, since the check has been changed from an error to a warning.

I'll consider that for a v2. My thought was that since we previously 
didn't care about the check at all, we don't want to start printing a 
warning now.

> Out of curiosity, which tool do you use to refresh Config-defaults.in?
> It seems to reorder items quite a lot

It does indeed. I picked it up from an earlier patch, where Mark 
Mentovai fixed the config I had not updated on an earlier update [1]:

* cd package/utils/busybox/config
* ../convert_menuconfig.pl .../build_dir/target-*/busybox-1.27.1
* cd ..
* ./convert_defaults.pl < \
   .../build_dir/target-*/busybox-1.27.1/.config > Config-defaults.in
* git diff package/utils/busybox/Config-defaults.in

I then go over the diff, review BusyBox history to see what automagic 
appears to make sense and what does not.

The items that are just reordered could probably just be left as is (no 
reordering). My first thought was "reorder now, less reordering in the 
future", but the BusyBox config is probably such a moving target that 
there is no real long term benefit. I'll consider making the patch more 
readable in a v2.

> Also, the previous update of busybox refreshed the configuration of all
> applets in config/, is it unneeded for this release?

I believe the "new applet" style came along with an upstream cleanup, 
introducing lots of renaming and moving of config symbols, as well as 
many new ones (I broke the config when I submitted the 1.26.2 update as 
well). This version has less of that, leading to less config/ updates.

1: https://patchwork.ozlabs.org/patch/547339/

Regards
/Magnus



More information about the Lede-dev mailing list