[LEDE-DEV] [PATCH] ramips: pinctrl: return proper error if pinctrl0 is empty

Mathias Kresin dev at kresin.me
Tue Jul 25 23:08:12 PDT 2017


Children of the pinctrl0 node are optional. Return EINVAL (=missing)
instead of 0. Fixes a hang if the pinctrl0 has no children.

Signed-off-by: Mathias Kresin <dev at kresin.me>
---
 .../ramips/patches-4.9/0025-pinctrl-ralink-add-pinctrl-driver.patch     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/ramips/patches-4.9/0025-pinctrl-ralink-add-pinctrl-driver.patch b/target/linux/ramips/patches-4.9/0025-pinctrl-ralink-add-pinctrl-driver.patch
index 6e0d643..dc45852 100644
--- a/target/linux/ramips/patches-4.9/0025-pinctrl-ralink-add-pinctrl-driver.patch
+++ b/target/linux/ramips/patches-4.9/0025-pinctrl-ralink-add-pinctrl-driver.patch
@@ -193,7 +193,7 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +	}
 +
 +	if (!max_maps)
-+		return max_maps;
++		return -EINVAL;
 +
 +	*map = kzalloc(max_maps * sizeof(struct pinctrl_map), GFP_KERNEL);
 +	if (!*map)
-- 
2.7.4




More information about the Lede-dev mailing list