[LEDE-DEV] [PATCH procd v3 1/2] init: Check chroot return value in sysupgrade_exec_upgraded()

Florian Fainelli f.fainelli at gmail.com
Thu Jul 20 08:32:37 PDT 2017


On 07/20/2017 05:39 AM, Matthias Schiffer wrote:
> On 07/19/2017 05:24 PM, Florian Fainelli wrote:
>> chroot() can fail and its return value should be checked against, in that case
>> do an exit() since this is a fatal condition that we cannot recover from.
>>
>> Fixes: 63789e51ed91 ("init: add support for sysupgrades triggered from preinit")
>> Signed-off-by: Florian Fainelli <f.fainelli at gmail.com>
>> ---
>>  sysupgrade.c | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Matthias Schiffer <mschiffer at universe-factory.net>
> 
> You should be able to push this yourself, otherwise I can do it later today
> (I'll also add another commit to change the sysupgrade() return code to
> UBUS_STATUS_UNKNOWN_ERROR).

Applied and pushed out, thanks!
-- 
Florian



More information about the Lede-dev mailing list