[LEDE-DEV] [PATCH 2/3] ubusd: rename goto label from `error` to `out`

Alexandru Ardelean ardeleanalex at gmail.com
Wed Jul 5 06:21:22 PDT 2017


Semantic has changed a bit.

Signed-off-by: Alexandru Ardelean <ardeleanalex at gmail.com>
---
 ubusd_proto.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/ubusd_proto.c b/ubusd_proto.c
index 441d084..b084b86 100644
--- a/ubusd_proto.c
+++ b/ubusd_proto.c
@@ -345,22 +345,22 @@ static int ubusd_handle_response(struct ubus_client *cl, struct ubus_msg_buf *ub
 	if (!attr[UBUS_ATTR_OBJID] ||
 	    (ub->hdr.type == UBUS_MSG_STATUS && !attr[UBUS_ATTR_STATUS]) ||
 	    (ub->hdr.type == UBUS_MSG_DATA && !attr[UBUS_ATTR_DATA]))
-		goto error;
+		goto out;
 
 	obj = ubusd_find_object(blob_get_u32(attr[UBUS_ATTR_OBJID]));
 	if (!obj)
-		goto error;
+		goto out;
 
 	if (cl != obj->client)
-		goto error;
+		goto out;
 
 	cl = ubusd_get_client_by_id(ub->hdr.peer);
 	if (!cl)
-		goto error;
+		goto out;
 
 	ub->hdr.peer = blob_get_u32(attr[UBUS_ATTR_OBJID]);
 	ubus_msg_send(cl, ub);
-error:
+out:
 	return -1;
 }
 
-- 
2.7.4




More information about the Lede-dev mailing list