[LEDE-DEV] [PATCH RFC 2/2] ramips: dts: add precompiler macro for VLAN defaults

[Daniel Golle]

Hi Florian,
On Wed, Feb 22, 2017 at 03:54:23PM -0800, Florian Fainelli wrote:
> 
> 
> On 02/22/2017 08:21 AM, Daniel Golle wrote:
> > Add new dt-bindings precompiler include to replace numerical default
> > VLAN assignments with more meaningful descriptive values, such that
> > 0x3f -> VLAN_CONFIG_LLLLL
> > 0x2f -> VLAN_CONFIG_LLLLW
> > 0x3e -> VLAN_CONFIG_WLLLL
> > 
> > In that we we get the best of both worlds: the usability of having
> > strings and all the freedom and simplicity of having just an 8-bit
> > field.
> 
> Why not bite the bullet and just migrate to the new DSA binding which
> allows you to describe all switch ports more exhaustively. That does not
> mean you need to implement a DSA switch register driver, but that does
> not mean you can't use use the same binding to describe your HW.

I agree, however, I'd rather take small iterative steps instead of
adding quite a lot of extra complexity, most of which is unneeded for
the way OpenWrt/LEDE currently works. Plus I don't know what's written
on all devices' Ethernet ports and which ports are actually physically
connected. Sidenote: John has added support for labeling individual
ports on rt305x a long time ago and the only board which is using that
is the FONERA2 which was the board he was using back then...
Thus, when implementing the DSA-like switch port description, we'd have
to keep the legacy mediatek,portmap attribute anyway and then migrate
board by board and apparently there is no ground to expect high
interest from users to help with that.
Apart from that, the mediatek,portmap is very similar to what people
find in MTK/Ralink's SDK menuconfig which makes it easy for people to
migrate from there to vanilla OpenWrt/LEDE.

The idea of my patch/rfc series is to unify the mediatek,portmap
attribute such that it'd be the same semantics for rt305x and mt76xx.
This will already allow to add more information than the current
implementation on mt76xx which basically just allows for two different
setups ("llllw" or "wllll").
Migrating the existing board-support to use a numeric attribute plus
precompiler macros is a matter of using sed and can easily be done all
at once.

I'm also planning to implement mediatek,disablemap for mt76xx in the
same way it works on rt305x.


Cheers


Daniel

> 
> See, e.g:
> 
> https://patchwork.kernel.org/patch/9493039/
> -- 
> Florian
> 
> _______________________________________________
> Lede-dev mailing list
> Lede-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev