[LEDE-DEV] [PATCH] ar71xx: fix gmac0 speed function for qca956x

Felix Fietkau nbd at nbd.name
Sat Feb 18 00:51:40 PST 2017


On 2017-02-18 07:54, hackpascal wrote:
> From: Weijie Gao <hackpascal at gmail.com>
> 
> This patch fixed the problem that kernel will crash when WAN port is
> linked-up in QCA9561.
> 
> When GMAC0 is configured as GMII, it's connected to the internal switch.
> In this situation, there's no need to adjust the speed of GMAC0, and the
> function ath79_set_speed_dummy should be used.
> 
> Prevoiusly this function was incorrectly set to ath79_set_speed_ge0,
> which is used for AR71XX/AR91XX. If WAN port is linked-up, this function
> will crash the kernel due to incorrect register access.
>From what I can see in the reference source code, QCA956x should be
treated in the same way as AR934x, and GMAC0 uses the internal switch
only as a PHY. Also, my change was tested and confirmed working by other
users. Where did you get your information from?

- Felix



More information about the Lede-dev mailing list