[LEDE-DEV] [OpenWrt-Devel] [PATCH] packages: Use https instead of git

[Felix Fietkau]

On 2017-02-15 13:20, Imre Kaloz wrote:
> Hi Alexey,
> 
> On 2017-02-15 11:11, Alexey Brodkin wrote:
>> From: Alexey Brodkin <Alexey.Brodkin at synopsys.com>
>>
>> On some [especially corporate] networks non-standard ports are blocked
>> and git is one of them. So switch to more convenient https transport.
>>
>> Signed-off-by: Alexey Brodkin <Alexey.Brodkin at synopsys.com>
> 
> Please make this a configuration option instead.
Please don't. Adding a configuration option for this is a waste of time
and only makes makefiles more convoluted.

This stuff is pretty much a non-issue for all packages that have
PKG_MIRROR_HASH (or the legacy PKG_MIRROR_MD5SUM) option set.
The LEDE buildbot automatically uploads mirrored tarballs to a place
that's referenced by download.pl.

This means that only in the rare case of the package update being too
new (or a broken makefile) it will actually attempt to download from
git. In all other cases it will pull the mirrored tarball from the LEDE
server, which should work properly with garbage firewalls.

Now if these packages don't have PKG_MIRROR_HASH set properly, that's
something actually worth fixing :)

- Felix