[LEDE-DEV] [PATCH] ar71xx: set status led for the gl-* boards

John Crispin john at phrozen.org
Wed Feb 15 00:29:03 PST 2017



On 14/02/2017 15:46, Wojciech Jowsa wrote:
> This sets status_led for the  gl-ar300m and gl-mifi boards.
> 
> Signed-off-by: Wojciech Jowsa <w.jowsa at radytek.com>
> ---
>  target/linux/ar71xx/base-files/etc/diag.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/target/linux/ar71xx/base-files/etc/diag.sh
> b/target/linux/ar71xx/base-files/etc/diag.sh
> index a407a99..df13c43 100644
> --- a/target/linux/ar71xx/base-files/etc/diag.sh
> +++ b/target/linux/ar71xx/base-files/etc/diag.sh
> @@ -63,6 +63,10 @@ get_status_led() {
>         gl-inet)
>                 status_led="$board:green:lan"
>                 ;;
> +       gl-ar300m|\
> +       gl-mifi)
> +               status_led="$board:lan"

Hi Wojciech,

patch is technically correct, however while reviewing it i noticed that
the boards do not follow the correct naming scheme. normally it should
be board:color:function. looks like the gl boards are missing the color.
would you mind re-spinning you patch and also fixing the colors inside
target/linux/ar71xx/files/arch/mips/ath79/mach-gl-ar300m.c and
target/linux/ar71xx/files/arch/mips/ath79/mach-gl-mifi.c

	John


> +               ;;
>         ap96)
>                 status_led="$board:green:led2"
>                 ;;
> 



More information about the Lede-dev mailing list