[LEDE-DEV] [PATCH 2/2] x86: Add board configs for the PC Engines APU2

David Woodhouse dwmw2 at infradead.org
Mon Feb 13 06:32:33 PST 2017

On Mon, 2017-02-13 at 12:50 +0100, Felix Fietkau wrote:
> Please leave out the /lib/<platform>.sh anti-pattern. Just use
> /tmp/sysinfo/board_name directly or (even better) introduce a generic
> function for getting the board name.

Once I stop /etc/diag.sh from having hard-coded board name stuff, we go
back to only one instance of reading /tmp/sysinfo/board_name — so I
dropped that part from https://github.com/lede-project/source/pull/824

Testing seems to show that the diag LED only really works from the
second boot though, since it isn't *configured* during the first boot.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4938 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/lede-dev/attachments/20170213/3bfed622/attachment.bin>

More information about the Lede-dev mailing list