[LEDE-DEV] [PATCH] BT Home Hub 5A: configure Red Ethernet as DMZ interface (FS#490) and fix Red Ethernet switch port (FS#390)

Mathias Kresin dev at kresin.me
Sat Feb 11 12:32:38 PST 2017


11.02.2017 18:55, Mauro M.:
> This proposed patch applies to BT Home Hub 5 Type A and:
>
> 1) it includes configuration for the Red Ethernet port as an additional
> "dmz" interface (feature request FS#490)

NAK.

It's a WAN port and not a DMZ port. It should be used by default as WAN 
port. If you need it as DMZ port, feel free to add your own _local_ 
configuration.

> 2) it fixes FS#390 providing the ability to associate port 5 to the main
> switch VLAN.

Looks exactly like one part of the changes I've in my staging tree to 
which I pointed you to. Or to be more clear, thanks for copying my code 
without mention the author.

Consider your patch as rejected. I pointed you to the commits in my 
staging tree which are properly fixing the issues you are seeing and 
some others you are not aware of.

I can only please you once more (the third time?) to test my staging 
tree as it is and report if there are still issues left or new issues 
introduced.

Mathias



More information about the Lede-dev mailing list