[LEDE-DEV] [PATCH mdns] Check correct attributes when loading service from blob

Rafał Miłecki zajec5 at gmail.com
Fri Feb 10 05:48:36 PST 2017


From: Rafał Miłecki <rafal at milecki.pl>

We access SERVICE_TXT so we should check for this entry. Checking
SERVICE_SERVICE doesn't make sense anyway as it's verified few lines
above (in the same funcion).

Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
---
 service.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/service.c b/service.c
index bb87aff..45b9345 100644
--- a/service.c
+++ b/service.c
@@ -229,7 +229,7 @@ service_load_blob(struct blob_attr *b)
 	if (!_tb[SERVICE_PORT] || !_tb[SERVICE_SERVICE])
 		return;
 
-	if (_tb[SERVICE_SERVICE])
+	if (_tb[SERVICE_TXT])
 		blobmsg_for_each_attr(txt, _tb[SERVICE_TXT], rem2)
 			txt_len += 1 + strlen(blobmsg_get_string(txt));
 
@@ -248,7 +248,7 @@ service_load_blob(struct blob_attr *b)
 	s->txt_len = txt_len;
 	s->txt = d_txt;
 
-	if (_tb[SERVICE_SERVICE])
+	if (_tb[SERVICE_TXT])
 		blobmsg_for_each_attr(txt, _tb[SERVICE_TXT], rem2) {
 			int len = strlen(blobmsg_get_string(txt));
 			if (!len)
-- 
2.11.0




More information about the Lede-dev mailing list