[LEDE-DEV] [PATCH] ar71xx: Support for TP-LINK MR6400

Sven Eckelmann sven.eckelmann at openmesh.com
Thu Feb 9 01:49:21 PST 2017

On Donnerstag, 9. Februar 2017 10:32:37 CET Filip Moc wrote:
> On Thu, Feb 09, 2017 at 09:40:31AM +0100, John Crispin wrote:
> > Hi,
> > 
> > there should be a "Signed-off-by:" line here. please resend the patch
> > with the line added.
> Actually there was "Signed-off-by:" line in my original email.
> If you look here https://lists.infradead.org/pipermail/lede-dev/2017-February/005728.html
> you can see it's really there. Perhaps some patchwork's magic cut it off.
> But anyway I wanted to make v2 since there are few things I wanted to fix.
> Hope I make it right with "Signed-off-by:" line this time.

Looks to me like you mixed up the basic structure of the commit message body
when sending patches via mail. Let's just have a look at it

    From 2a930f515c38069c2e57ef76f0ffe0d8e2ab115a Mon Sep 17 00:00:00 2001
    From: Filip Moc <lede at moc6.cz>
    Date: Sat, 4 Feb 2017 14:37:08 +0100
    Subject: [LEDE-DEV] [PATCH] ar71xx: Support for TP-LINK MR6400

This part belongs in the the mail body. It should be in the mail headers
    Add support for TP-Link MR6400
    Everything seems to be working.
    You can flash via u-boot tftp (serve factory image as /mr6400_tp_recovery.bin
    on, connect to any ethernet port and power on device while
    holding the reset button).
    File ar71xx/base-files/etc/init.d/enablemodem is based on
    ramips/base-files/etc/init.d/enablemodem. Code of enablemodem does not seem
    to be platform specific and I think it should be shared.
    I suggest merging these files and moving result to adb package.
    Another question is how to get board info.
    Maybe from `cat /tmp/sysinfo/board_name` or from '/etc/board.json'?

This is a little bit strange commit message. Maybe you wanted to put this in
the cover letter for this patch? The cover letter should have been sent
separately and the patch as reply to the cover letter.

Here you end something? The cover letter? See above why this is wrong here.
    From 2a930f515c38069c2e57ef76f0ffe0d8e2ab115a Mon Sep 17 00:00:00 2001
    From: Filip Moc <lede at moc6.cz>
    Date: Sat, 4 Feb 2017 10:31:06 +0100
    Subject: [PATCH] Add support for TL-MR6400

Again, the from, date and Subject should be in the mail header and not the
mail body.
    Signed-off-by: Filip Moc <lede at moc6.cz>

The Signed-off-by: Line is after a ---. So every git tool will have ignored
it (including helper tools like patchwork).

You should check out git-send-email or use "mutt -H" for sending patches [1]

Kind regards,

[1] https://kernel.org/doc/html/latest/process/email-clients.html#mutt-tui
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/lede-dev/attachments/20170209/5b35fcea/attachment.sig>

More information about the Lede-dev mailing list