[LEDE-DEV] [PATCH 2/2] target/generic: update settings of mx25u3235f

[Arjen de Korte]

Citeren André Valentin <avalentin at marcant.net>:

> This patch enabled 4K, dual and quad read. Settings have been verified with
> a real device.
>
> Signed-off-by: André Valentin <avalentin at marcant.net>

This is a bit tricky. While one can detect that a specific SPI NOR  
device has SECT_4K capability (this is a property of the SPI device  
itself), whether or not the SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ  
works also depends on how it is connected. In your device, this  
apparently works, but this doesn't mean it will work in all device  
that use this (now and in the future). I seriously doubt that setting  
these values in any other place than a device specific configuration  
file is a good idea.

> ---
>   
> .../linux/generic/patches-4.4/477-mtd-add-spi-nor-add-mx25u3235f.patch  | 2  
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git  
> a/target/linux/generic/patches-4.4/477-mtd-add-spi-nor-add-mx25u3235f.patch  
> b/target/linux/generic/patches-4.4/477-mtd-add-spi-nor-add-mx25u3235f.patch
> index fa1ab3f..c2a28a0 100644
> ---  
> a/target/linux/generic/patches-4.4/477-mtd-add-spi-nor-add-mx25u3235f.patch
> +++  
> b/target/linux/generic/patches-4.4/477-mtd-add-spi-nor-add-mx25u3235f.patch
> @@ -4,7 +4,7 @@
>   	{ "mx25l3205d",  INFO(0xc22016, 0, 64 * 1024,  64, SECT_4K) },
>   	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
>   	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> -+	{ "mx25u3235f",	 INFO(0xc22536, 0, 64 * 1024, 64, 0) },
> ++	{ "mx25u3235f",	 INFO(0xc22536, 0, 64 * 1024, 64, SECT_4K |  
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>   	{ "mx25u6435f",  INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
>   	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>   	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },