[LEDE-DEV] [PATCH hauke/kernel-4.14-sunxi 0/4] add LEDE support for NanoPi NEO Plus2 board

[Antony Antony]

Hi Hauke,

thanks for your response. I appreciate it. 

On Fri, Dec 29, 2017 at 01:53:46PM +0100, Hauke Mehrtens wrote:
> Hi antony,
> 
> On 12/28/2017 06:21 PM, Antony Antony wrote:
> > Hi Hauke,
> > 
> > This will add initial LEDE support for a new board, NanoPi NEO Plus2 board.
> > 
> > LEDE menu options, u-boot, and kernel DT files. The patches are against hauke/kernel-4.14-sunxi branch.
> 
> Ok this is my development branch, now I send the patches to the list.

I know it is a long shot to send you patch against a rapidly changing 
development branch. I think this is the best fit. Kernel 4.14 is good base 
for this sunxi H5 board. I would appreciate if you could apply the patches 
to your branch. And feel free to modify it afterwards in any way your branch 
move forward.

> > The patches are in upstream.
> > Kernel DT initial support is in 4.15 and Gigabit support is queued for 4.16.
> > u-boot support is #master, it will be in 2018.01
> 
> You split the patches in a strange way.
> I would suggest to have only two patches, one adding the changes needed
> for U-Boot and one for the kernel and image build. Your current split
> will have problems with git bisect when only your first patch is applied.

thanks for the feedback. Now I have a better idea how to split it. I was not 
sure what would be optimal split.

> Otherwise these patches are looking good.

great thanks. I will send new version out soon.

regards,
-antony