[LEDE-DEV] [PATCH] procd: initd: fix path allocation in early_insmod

Nathan Hintz nlhintz at hotmail.com
Thu Dec 28 20:48:26 PST 2017


Noticed that /tmp was not being created on /dev/zram0.  This was on
ixp4xx (nslu2) using GCC 6.3 and musl.

The allocation should be using the length of the passed string
(module path), not the size of the pointer to the string.

Signed-off-by: Nathan Hintz <nlhintz at hotmail.com>
---
 initd/zram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/initd/zram.c b/initd/zram.c
index 0e78195..da1795a 100644
--- a/initd/zram.c
+++ b/initd/zram.c
@@ -60,7 +60,7 @@ early_insmod(char *module)
 		struct utsname ver;
 
 		uname(&ver);
-		path = alloca(sizeof(module) + strlen(ver.release) + 1);
+		path = alloca(strlen(module) + strlen(ver.release) + 1);
 		sprintf(path, module, ver.release);
 		modprobe[1] = path;
 		execvp(modprobe[0], modprobe);
-- 
2.13.6




More information about the Lede-dev mailing list