[LEDE-DEV] [PATCH] firewall3: Enable TCP_ECN by default.

[Rosen Penev]

On Tue, Dec 12, 2017 at 6:07 AM, John Crispin <john at phrozen.org> wrote:
>
>
> On 03/10/17 09:16, Rosen Penev wrote:
>>
>> ECN is used by fq_codel and other AQMs. Kernel 4.2 added a fallback in
>> case of failure, so adjust to kernel default.
>>
>> Signed-off-by: Rosen Penev <rosenp at gmail.com>
>> ---
>>   defaults.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/defaults.c b/defaults.c
>> index 85a3750..68e40f5 100644
>> --- a/defaults.c
>> +++ b/defaults.c
>> @@ -90,6 +90,7 @@ fw3_load_defaults(struct fw3_state *state, struct
>> uci_package *p)
>>         defs->syn_flood_rate.rate  = 25;
>>         defs->syn_flood_rate.burst = 50;
>> +       defs->tcp_ecn              = 2;
>>         defs->tcp_syncookies       = true;
>>         defs->tcp_window_scaling   = true;
>>         defs->custom_chains        = true;
>
>
> from kevins reply i gather that this is a no-op setting the default which is
> already set and that the description is incorrect as there is no fallback
> when setting 2 as a value. please rework the patch if you still want it
> applied.

>
>     John