[LEDE-DEV] [PATCH 5/5] ag71xx: remove dma_unmap_single as it is no-op.

Felix Fietkau nbd at nbd.name
Mon Dec 4 12:10:51 PST 2017


On 2017-12-04 20:40, Rosen Penev wrote:
> Qualcomm claims this is no-op for MIPS. Original commit message below:
> 
> From: Ben Menchaca <ben.menchaca at qca.qualcomm.com>
> Date: Fri, 7 Jun 2013 11:19:08 -0500
> Subject: [ag71xx] DMA unmap FROM_DEVICE no-op for our arch
> 
> The invalidate for FROM_DEVICE map/unmap pairs is done in the map.
> The unmap is a no-op, but there is a cost for accessing that no-op
> function through the large number of indirection layers presented
> by the MIPS linux dma_ops.
> 
> Signed-off-by: Ben Menchaca <ben.menchaca at qca.qualcomm.com>
> Signed-off-by: Rosen Penev <rosenp at gmail.com>
NACK for this patch. It's true that dma-unmap is a no-op for most MIPS
devices, but I will take care of this in a generic way instead of
merging this driver specific hack.

- Felix



More information about the Lede-dev mailing list