[LEDE-DEV] [PATCH] procd: mdns: Support txt values with spaces
Karl Palsson
karlp at etactica.com
Wed Aug 30 10:44:00 PDT 2017
Properly quote the arguments so that you can register a service with TXT
entries that contains spaces.
Example:
procd_add_mdns myservice tcp 9999 "key=descriptive text field 1" \
"another=something equally verbose"
Output before:
$ avahi-browse -r -v _myservice._tcp
_myservice._tcp local
hostname = [blah.local]
address = [192.168.255.74]
port = [9999]
txt = ["verbose" "equally" "another=something" "1" "field" "text" "key=descriptive"]
Output now:
$ avahi-browse -r -v _myservice._tcp
_myservice._tcp local
hostname = [blah.local]
address = [192.168.255.74]
port = [9999]
txt = ["another=something equally verbose" "key=descriptive text field 1"]
Signed-off-by: Karl Palsson <karlp at etactica.com>
---
package/system/procd/files/procd.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/system/procd/files/procd.sh b/package/system/procd/files/procd.sh
index 00d754d16ff0..c23c37b83f00 100644
--- a/package/system/procd/files/procd.sh
+++ b/package/system/procd/files/procd.sh
@@ -423,7 +423,7 @@ procd_add_mdns_service() {
json_add_int port "$port"
[ -n "$1" ] && {
json_add_array txt
- for txt in $@; do json_add_string "" $txt; done
+ for txt in "$@"; do json_add_string "" "$txt"; done
json_select ..
}
json_select ..
@@ -432,7 +432,7 @@ procd_add_mdns_service() {
procd_add_mdns() {
procd_open_data
json_add_object "mdns"
- procd_add_mdns_service $@
+ procd_add_mdns_service "$@"
json_close_object
procd_close_data
}
--
2.4.11
More information about the Lede-dev
mailing list