[LEDE-DEV] Conditional dependencies in Makefiles

[Ted Hess]

Hi Felix -

You make a good point here about the way we constructed the ffmpeg-full dependencies. We do need to re-think its configuration and 
somehow NOT create a 4th permanent build. Currently we have an ffmpeg-custom package which is not normally built but can be used for 
a custom tailored config in a private build.

We should also figure out if we need to be including high resource (CPU) encoders (like shine, x264 and lame) in all default builds. 
They are currently in the default buildbot packages since the optional libs are selected by CONFIG_ALL.

Thanks for suggestion on intermediate config symbols (as we do with -custom) -- will give this a try.

Regards,
/ted

-----Original Message----- 
From: Felix Fietkau
Sent: Tuesday, August 29, 2017 3:04 PM
To: Ted Hess ; lede-dev
Subject: Re: [LEDE-DEV] Conditional dependencies in Makefiles

Please don't introduce dependencies that magically get added based on
whether a different package is selected or not.
Either always use shine, or add a separate option to configure whether
or not it should be used.
Also make sure that anything that affects the build gets proper
treatment in CONFIGURE_ARGS and PKG_CONFIG_DEPENDS.

Aside from that, there is an easy way to deal with conditional
dependencies that depend on multiple options: Just create an
intermediate config symbol via Package/<foo>/config that is hidden and
depends on the relevant multiple config symbols.

- Felix

_______________________________________________
Lede-dev mailing list
Lede-dev at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev