[LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts: enable ttyS1

[John Crispin]

Hi,

comment inline


On 26/08/17 21:54, Zoltan Gyarmati wrote:
>   The RT5350F's second UART pins are available on the base module and on
> the EVB as well, so enable it in the device tree.
>   Additionaly, the uartlite at c00 and uart at 500 nodes swapped in rt5350.dtsi
> to keep the serial console as ttyS0.
>
> Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati at gmail.com>
> ---
>   target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi | 11 +++++++++-
>   target/linux/ramips/dts/rt5350.dtsi            | 30 +++++++++++++-------------
>   2 files changed, 25 insertions(+), 16 deletions(-)
>
> diff --git a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi
> index 955a13cddd..1632f3c085 100644
> --- a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi
> +++ b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi
> @@ -46,9 +46,13 @@
>   &pinctrl {
>   	state_default: pinctrl0 {
>   		gpio {
> -			ralink,group = "jtag", "rgmii", "mdio", "uartf";
> +			ralink,group = "jtag", "rgmii", "mdio";
>   			ralink,function = "gpio";
>   		};
> +		uartf_gpio {
> +			ralink,group = "uartf";
> +			ralink,function = "gpio uartf";
> +		};
>   	};
>   };
>   
> @@ -77,3 +81,8 @@
>   &i2c {
>   	status = "okay";
>   };
> +
> +&uart {
> +	status = "okay";
> +};
> +
> diff --git a/target/linux/ramips/dts/rt5350.dtsi b/target/linux/ramips/dts/rt5350.dtsi
> index a92c113043..f027e17d9d 100644
> --- a/target/linux/ramips/dts/rt5350.dtsi
> +++ b/target/linux/ramips/dts/rt5350.dtsi
> @@ -83,21 +83,6 @@
>   			interrupts = <3>;
>   		};
>   
> -		uart: uart at 500 {
> -			compatible = "ralink,rt5350-uart", "ralink,rt2880-uart", "ns16550a";
> -			reg = <0x500 0x100>;
> -
> -			resets = <&rstctrl 12>;
> -			reset-names = "uart";
> -
> -			interrupt-parent = <&intc>;
> -			interrupts = <5>;
> -
> -			reg-shift = <2>;
> -
> -			status = "disabled";
> -		};
> -
>   		gpio0: gpio at 600 {
>   			compatible = "ralink,rt5350-gpio", "ralink,rt2880-gpio";
>   			reg = <0x600 0x34>;
> @@ -221,6 +206,21 @@
>   			reg-shift = <2>;
>   		};
>   
> +		uart: uart at 500 {
> +			compatible = "ralink,rt5350-uart", "ralink,rt2880-uart", "ns16550a";
> +			reg = <0x500 0x100>;
> +
> +			resets = <&rstctrl 12>;
> +			reset-names = "uart";
> +
> +			interrupt-parent = <&intc>;
> +			interrupts = <5>;
> +
> +			reg-shift = <2>;
> +
> +			status = "disabled";
> +		};

moving the node makes no sense. the change is a no-op. please remove it 
and update the patch description

     John

> +
>   		systick: systick at d00 {
>   			compatible = "ralink,rt5350-systick", "ralink,cevt-systick";
>   			reg = <0xd00 0x10>;