[LEDE-DEV] [PATCH] brcm63xx: Add Sercomm AD1018 support

[Daniel]

2017-08-26 12:26 GMT+02:00 Jonas Gorski <jonas.gorski at gmail.com>:
> Hi,

>> +};
>> +
>> +&leds {
>> +       status = "ok";
>> +
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_led0 &pinctrl_led1 &pinctrl_serial_led
>> +                    &pinctrl_ephy0_spd_led &pinctrl_ephy1_act_led
>> +                    &pinctrl_ephy2_act_led &pinctrl_ephy3_act_led>;
>
> What's up with ephy1~3 using act, but 0 using the spd led? is this intentional?

Yes, it is intentional. The "FIBRE" port (port0)  uses an spd LED
whereas the rest of "LAN1-3" (ports3-1) use act LEDs.

>> +
>> +       brcm,serial-leds;
>> +       brcm,serial-shift-inv;
>> +       brcm,serial-dat-low;
>> +
>> +       inet_red at 0 {
>> +               reg = <0>;
>> +               active-low;
>> +               label = "AD1018:red:internet";
>> +       };
>> +
>> +       inet_green at 1 {
>> +               reg = <1>;
>> +               active-low;
>> +               label = "AD1018:green:internet";
>> +       };
>> +
>> +       power_green at 8 {
>> +               reg = <8>;
>> +               active-low;
>> +               label = "AD1018:green:power";
>> +               default-state = "on";
>> +       };
>> +
>> +       adsl_green at 10 {
>> +               reg = <10>;
>> +               active-low;
>> +               label = "AD1018:green:adsl";
>> +       };
>> +
>> +       adsl_red at 11 {
>> +               reg = <11>;
>> +               active-low;
>> +               label = "AD1018:red:adsl";
>> +       };
>> +       phone_green at 12 {
>> +               reg = <12>;
>> +               active-low;
>> +               label = "AD1018:green:phone";
>> +       };
>> +
>> +       wps_green at 13 {
>> +               reg = <13>;
>> +               active-low;
>> +               label = "AD1018:green:wps";
>> +       };
>> +
>> +       wifi_green at 14 {
>> +               reg = <14>;
>> +               active-low;
>> +               label = "AD1018:green:wifi";
>> +       };
>> +
>> +       ephy0_spd at 17 {
>> +               reg = <17>;
>> +               brcm,hardware-controlled;
>> +       };
>> +};
>> +
>> +&hsspi {
>> +       status = "ok";
>> +
>> +       flash at 0 {
>> +               compatible = "jedec,spi-nor";
>> +               spi-max-frequency = <16666667>;
>> +               spi-tx-bus-width = <2>;
>> +               spi-rx-bus-width = <2>;
>> +               reg = <0>;
>> +
>> +               #address-cells = <1>;
>> +               #size-cells = <1>;
>> +
>> +               linux,part-probe = "bcm63xxpart";
>
> Partitions please.
>

I would prefer leave it without partitioning. This way we can use an
8, 16 or 32 MB SPI NOR flash without redefining partitions with a
custom firmware.

Regards