[LEDE-DEV] Issues with xtables-addons after rebasing today

Tue Aug 22 23:29:02 PDT 2017

Citeren John Crispin <john at phrozen.org>:

> On 23/08/17 05:34, Philip Prindeville wrote:
>>> On Aug 22, 2017, at 1:56 PM, Arjen de Korte  
>>> <arjen+lede at de-korte.org> wrote:
>>>
>>> Citeren Philip Prindeville <philipp_subx at redfish-solutions.com>:
>>>
>>>> Found the issue, and posted PR #1308 to fix it.  One-line fix.
>>>>
>>>>
>>>>> On Aug 19, 2017, at 3:06 PM, Philip Prindeville  
>>>>> <philipp_subx at redfish-solutions.com> wrote:
>>>>>
>>>>> And it looks like Hannu is way ahead of me:
>>>>>
>>>>> https://bugs.lede-project.org/index.php?do=details&task_id=969
>>>>>
>>>>>
>>>>>> On Aug 19, 2017, at 2:59 PM, Philip Prindeville  
>>>>>> <philipp_subx at redfish-solutions.com> wrote:
>>>>>>
>>>>>> I rebased about an hour ago and then tried to rebuild  
>>>>>> everything.  Now I’m seeing what’s below.
>>>>>>
>>>>>> I looked at the commit logs, though, and nothing stands out as  
>>>>>> a likely culprit… except maybe the bump from 4.9.40 to 4.9.44.
>>>>>>
>>>>>> If I rebase back to
>>>>>>
>>>>>> d9564d7 bcm53xx: backport DTS commits that setup USB LEDs
>>>>>>
>>>>>> then things build again.
>>>>>>
>>>>>>
>>>>>> . /home/philipp/bertram/lede/include/shell.sh; export modules=;  
>>>>>> probe_module() { local mods="$1"; local boot="$2"; local  
>>>>>> params="$3"; local mod; shift 3; for mod in $mods; do mkdir -p  
>>>>>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; local mod_params=""; for param in $params; do case $param in $mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp; done; if [ -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp ]; then if [ "$boot" = "1" -a ! -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp ]; then mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; ln -s ../modules.d/ipt-nathelper-rtsp /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; fi; modules="${modules:+$modules }$mods"; fi; }; add_module() { local priority="$1"; local mods="$2"; local boot="$3"; local params="$4"; local mod; shift 4; for mod in $mods; do mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; local mod_params=""; for param in $params; do case $param in $mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp; done; if [ -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp ]; then if [ "$boot" = "1" -a ! -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/$priority-ipt-nathelper-rtsp ]; then mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; ln -s ../modules.d/$priority-ipt-nathelper-rtsp /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; fi; modules="${modules:+$modules }$priority-ipt-nathelper-rtsp"; fi; }; probe_module "nf_conntrack_rtsp nf_nat_rtsp" "" ""; if [ -n "$modules" ]; then modules="$(echo "$modules" | tr ' ' '\n' | sort | uniq | paste -s -d' ' -)"; mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL; echo "#!/bin/sh" > /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; echo "[ -z \"\$IPKG_INSTROOT\" ] || exit 0" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; echo ". /lib/functions.sh" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; echo "insert_modules $modules" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; chmod 0755 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg;  
>>>>>> fi
>>>>>> find  
>>>>>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp -name 'CVS' -o -name '.svn' -o -name '.#*' -o -name '*~'| xargs -r rm  
>>>>>> -rf
>>>>>> Package kmod-ipt-nathelper-rtsp is missing dependencies for the  
>>>>>> following libraries:
>>>>>> nf_conntrack.ko
>>>>>> nf_nat.ko
>>>>>> Makefile:128: recipe for target  
>>>>>> '/home/philipp/bertram/lede/bin/targets/x86/64/packages/kmod-ipt-nathelper-rtsp_4.9.44+2.12-1_x86_64.ipk'  
>>>>>> failed
>>>>>> make[3]: ***  
>>>>>> [/home/philipp/bertram/lede/bin/targets/x86/64/packages/kmod-ipt-nathelper-rtsp_4.9.44+2.12-1_x86_64.ipk] Error  
>>>>>> 1
>>>>>> make[3]: Leaving directory  
>>>>>> '/home/philipp/bertram/lede/package/network/utils/xtables-addons'
>>>>>> package/Makefile:109: recipe for target  
>>>>>> 'package/network/utils/xtables-addons/compile' failed
>>>>>> make[2]: *** [package/network/utils/xtables-addons/compile] Error 2
>>>>>> make[2]: Leaving directory '/home/philipp/bertram/lede'
>>>>>> package/Makefile:105: recipe for target  
>>>>>> '/home/philipp/bertram/lede/staging_dir/target-x86_64_musl_powercode-bmu/stamp/.package_compile'  
>>>>>> failed
>>>>>> make[1]: ***  
>>>>>> [/home/philipp/bertram/lede/staging_dir/target-x86_64_musl_powercode-bmu/stamp/.package_compile] Error  
>>>>>> 2
>>>>>> make[1]: Leaving directory '/home/philipp/bertram/lede'
>>>>>> /home/philipp/bertram/lede/include/toplevel.mk:207: recipe for  
>>>>>> target 'world' failed
>>> There is still another issue with xtables-addons. If  
>>> kmod-ipt-tarpit is selected, it fails in a similar fashion, but  
>>> with a missing dependency on x_tables.ko. The reporter of FS#969  
>>> mentioned something similar for kmod-ipt-dhcpmac and  
>>> kmod-ipt-ipmark, so I believe there is a common problem leading up  
>>> to this.
>>>
>>
>> Yeah, I’m seeing it now with kmod-ipt-account... so something is  
>> definitely broken.
>
> which commit introduced the breakage ?

In my case, it was

     commit 4a1b87aba448fae648bf17830379fde11060927b (kernel: update  
4.4 to 4.4.83)

But something weird is going on. Directly after applying this commit,  
I could successfully build (with kmod-ipt-tarpit). But only once.