[LEDE-DEV] [PATCH 2/2] toolchain: gcc: drop MIPS patch

Philip Prindeville philipp_subx at redfish-solutions.com
Tue Aug 22 12:24:36 PDT 2017


> On Aug 22, 2017, at 4:01 AM, Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk> wrote:
> 
> Drop 300-mips_Os_cpu_rtx_cost_model.patch for gcc 7.2
> 
> This was causing mis-compilation of dropbear with the default '-Os' size
> optimization as reported in FS#814
> 
> Tested on ar71xx, archer C7 v2.  For size comparison of my whole build:
> 
> 12058628 O2-withoutpatch-dropbearworks.bin
> 12058628 O2-withpatch-dropbearworks.bin
> 11468804 Os-withoutpatch-dropbearworks.bin
> 11468804 Os-withpatch-dropbearfails.bin
> 
> Signed-off-by: Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk>
> ---
> .../7.2.0/300-mips_Os_cpu_rtx_cost_model.patch      | 21 ---------------------
> 1 file changed, 21 deletions(-)
> delete mode 100644 toolchain/gcc/patches/7.2.0/300-mips_Os_cpu_rtx_cost_model.patch
> 
> diff --git a/toolchain/gcc/patches/7.2.0/300-mips_Os_cpu_rtx_cost_model.patch b/toolchain/gcc/patches/7.2.0/300-mips_Os_cpu_rtx_cost_model.patch
> deleted file mode 100644
> index 84c0fda..0000000
> --- a/toolchain/gcc/patches/7.2.0/300-mips_Os_cpu_rtx_cost_model.patch
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -commit ecf7671b769fe96f7b5134be442089f8bdba55d2
> -Author: Felix Fietkau <nbd at nbd.name>
> -Date:   Thu Aug 4 20:29:45 2016 +0200
> -
> -gcc: add a patch to generate better code with Os on mips
> -
> -Also happens to reduce compressed code size a bit
> -
> -Signed-off-by: Felix Fietkau <nbd at nbd.name>
> -
> ---- a/gcc/config/mips/mips.c
> -+++ b/gcc/config/mips/mips.c
> -@@ -19784,7 +19784,7 @@ mips_option_override (void)
> -     flag_pcc_struct_return = 0;
> - 
> -   /* Decide which rtx_costs structure to use.  */
> --  if (optimize_size)
> -+  if (0 && optimize_size)
> -     mips_cost = &mips_rtx_cost_optimize_size;
> -   else
> -     mips_cost = &mips_rtx_cost_data[mips_tune];
> -- 
> 2.7.4



LGTM




More information about the Lede-dev mailing list