[LEDE-DEV] busybox ntpd not syncing if any server is bad

[Hans Dedecker]

On Thu, Aug 17, 2017 at 3:13 PM, Karl Palsson <karlp at tweak.net.au> wrote:
>
> Hans Dedecker <dedeckeh at gmail.com> wrote:
>> On Thu, Aug 17, 2017 at 1:25 PM, Karl Palsson
>> <karlp at tweak.net.au> wrote:
>> >
>> > Ok, so this was broken after busybox 1.23.2 and not fixed until
>> > 1.27 via
>> >
>> > https://git.busybox.net/busybox/commit/networking/ntpd.c?id=b62ea34afed7d3bf60a6c8ef5a030fea52f55b10
>> >
>> > Presumably updating busybox in master isn't exactly on the
>> > roadmap. Would a backport of this patch be acceptable for both
>> > 17.01 and master?
>> I'm in favor to backport the patch to 17.01; for master there's
>> a pending patch to upstep to busybox 1.27
>> (https://patchwork.ozlabs.org/patch/801034/)
>
>
> I've actually been testing the backport of the patch to ntpd
> alone, and while it appears to do the right thing, it still never
> actually syncs. (See below)
>
> Hans: does your 1.27 update actually work? (there's a bunch of
> other changes in 1.27, I only backported the ntpd patch)
No idea if ntpd actually works as I did not (yet) test the upstep to
busybox 1.27.1

Hans
>
> Nathanial: Is this what's _meant_ be happening after your patch?
> It certainly _looks_ better, but isn't actually syncing...
>
> Sincerely,
> Karl Palsson
>
>
> # /usr/sbin/ntpd -d -n -N -l -S /usr/sbin/ntpd-hotplug -p 0.lede.pool.ntp.org  -p working.good.org
> ntpd: bad address '0.lede.pool.ntp.org'
> ntpd: sending query to 192.168.255.124
> ntpd: bad address '0.lede.pool.ntp.org'
> ntpd: reply from 192.168.255.124: offset:-2.453565 delay:5.006456
> status:0x24 strat:3 refid:0xc1043a2c rootdelay:0.001495
> reach:0x01 ntpd: bad address '0.lede.pool.ntp.org' ntpd: sending
> query to 192.168.255.124 ntpd: bad address '0.lede.pool.ntp.org'
> ntpd: reply from 192.168.255.124: offset:-2.452851 delay:5.005238
> status:0x24 strat:3 refid:0xc1043a2c rootdelay:0.001495
> reach:0x03 ntpd: bad address '0.lede.pool.ntp.org' ntpd: sending
> query to 192.168.255.124 ntpd: bad address '0.lede.pool.ntp.org'
> ntpd: reply from 192.168.255.124: offset:-2.453057 delay:5.006114
> status:0x24 strat:3 refid:0xc1043a2c rootdelay:0.001495
> reach:0x07 ntpd: bad address '0.lede.pool.ntp.org' ntpd: sending
> query to 192.168.255.124 ntpd: bad address '0.lede.pool.ntp.org'
> ntpd: reply from 192.168.255.124: offset:-2.452234 delay:5.004736
> status:0x24 strat:3 refid:0xc1043a2c rootdelay:0.001495
> reach:0x0f ntpd: bad address '0.lede.pool.ntp.org' ntpd: bad
> address '0.lede.pool.ntp.org' ntpd: bad address
> '0.lede.pool.ntp.org' ntpd: bad address '0.lede.pool.ntp.org'
> ntpd: bad address '0.lede.pool.ntp.org' ntpd: bad address
> '0.lede.pool.ntp.org' ntpd: bad address '0.lede.pool.ntp.org'
> ntpd: sending query to 192.168.255.124 ntpd: bad address
> '0.lede.pool.ntp.org' ntpd: reply from 192.168.255.124:
> offset:-2.452024 delay:5.005580 status:0x24 strat:3
> refid:0xc1043a2c rootdelay:0.001495 reach:0x1f ntpd: bad address
> '0.lede.pool.ntp.org' ntpd: bad address '0.lede.pool.ntp.org'
> ntpd: bad address '0.lede.pool.ntp.org' ntpd: bad address
> '0.lede.pool.ntp.org' .....continues forever.... (reach gets up
> to 0xff, but otherwise no change)