[LEDE-DEV] [PATCH 1/5] base-files: introduce /lib/functions/board.sh

Bastian Bittorf bb at npl.de
Sun Apr 30 02:23:39 PDT 2017


* Felix Fietkau <nbd at nbd.name> [30.04.2017 09:30]:
> > +board_name()
> > +{
> > +	sysinfo board_name
> > +}
> > +
> > +board_model()
> > +{
> > +	sysinfo model
> > +}

> Do we really need board_model() at all? I think it's better to leave the
> board_name() function where it is instead of adding this extra include file.

the difference is that:

# root at box:~ cat /tmp/sysinfo/model 
# TP-Link TL-WDR4300 v1
# root at box:~ cat /tmp/sysinfo/board_name 
# tl-wdr4300

we use 'model' e.g. for our monitoring.

bye, bastian



More information about the Lede-dev mailing list