[LEDE-DEV] [PATCH] ar71xx: add Engenius ENH200EXT support

[Paul Oranje]

See comments/questions inline below.
-- 
Paul Oranje


> Op 1 apr. 2017, om 02:00 heeft Daniel Golle <daniel at makrotopia.org> het volgende geschreven:
> 
> Hi Paul,
> 
> On Fri, Mar 31, 2017 at 10:38:39PM +0200, Paul Oranje wrote:
>> This POE access point suited for outside usage needs an external antenna.
>> According FCC documentation the ENH200EXT (needs external antenna) and the ENH200 (with internal antenna) are electrically equal to the Allnet ALL0258N.
>> 
>> The stock image does not allow install of a LEDE factory image, but an initramfs image (lede-ar71xx-generic-enh200ext-initramfs-uImage.bin) can be loaded via u-boot recovery procedure (long press reset at power-on until all LEDS burn). The u-boot recovery procedure boots an image named vmlinux-art-ramdisk from 192.168.1.101.
>> Once booted the sysupgrade image can be flashed from the booted iniramfs LEDE.
>> 
>> Only abnormality is that for some unknown reason the txpower cannot be set higher than 16 dBm whereas the Engenius stock firmware allows a maximum of 27 dBm.
> 
> Yes, difference is software only. ALL0258N came with OpenWrt
> pre-flashed, hence we contributed the needed bits upstream. Also went
> through ODM QA with OpenWrt, so EEPROM might not be identical for
> ENH200 and ALL0258N (the latter was intended to run OpenWrt with ath9k
> as well as Atheros SDK's proprietary driver).
Could the lower maximum txpower be the result of not running with the proprietary driver ?
> 
>> 
>> Signed-off-by: Paul Oranje <por at xs4all.nl>
>> ---
>> package/boot/uboot-envtools/files/ar71xx           |  1 +
>> target/linux/ar71xx/base-files/etc/board.d/01_leds |  3 +-
>> .../linux/ar71xx/base-files/etc/board.d/02_network |  1 +
>> target/linux/ar71xx/base-files/lib/ar71xx.sh       |  3 +
>> .../ar71xx/base-files/lib/upgrade/platform.sh      |  6 +-
>> target/linux/ar71xx/config-4.4                     |  1 +
>> .../ar71xx/files/arch/mips/ath79/Kconfig.openwrt   |  9 +++
>> target/linux/ar71xx/files/arch/mips/ath79/Makefile |  1 +
>> .../ar71xx/files/arch/mips/ath79/mach-enh200ext.c  | 89 ++++++++++++++++++++++
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Please merge this with mach-all0258n.c so we don't have tons of
> redundant code. Make them share most of the setup code, maybe
> parametrisize the LEDs so you can pass a string and then just have
> two MIPS_MACHINE lines at the bottom of the file. Take a look at
> various mach-tl-*.c files which usually are for several similar
> models each.
What would the source file with the merged support be named, mach-all0258n.c, mach-enh20x.c, or … ?

A few more questions:
Apart from this file and putting the dev’s make stances in generic.mk, which of the other files that were patched with the v1 patch should be handled differently ?
When changing the make stances, what is a good way to rebuild the config without going through make clean (my build laptop sports just 3 GB and an Intel C2D, so a complete build does take quite some time) ?


> 
> Cheers
> 
> Daniel
> 
> _______________________________________________
> Lede-dev mailing list
> Lede-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev